> the benefits of comprehensive updates which we believe these topology files 
> for particular Intel platform 
> (ex. sof-lnl/arl/mtl/...-$(codec_name)-xxxx) are signed and verified by Intel 
> and would be advantageous 
> in the long run.

While I can appreciate that, it's not the topic of this SRU. In this
SRU, you are enabling "cs42l43 and cs35l56 audio on Intel LNL". But
there are dozens and dozens of other changes.

Furthermore, you are still claiming in the bug description that only
cirrus audio could regress:

"""
  It may break cirrus audio support.
"""

Is that really true, given all the other topology files you are
updating?

And:

> The development of firmware-sof follows the standards of the upstream Linux 
> community. It ensures 
> firmware-sof package aligns with the broader Linux ecosystem to avoids 
> compatibility issues. Updating 
> only part of the files would require multiple SRUs, testing and verification 
> cycles for the 
> new/existing audio configurations which are also expected to be supported by 
> Ubuntu.

If you want to update all those other binary files, then your bug description 
must reflect that. As it is now, your bug is:
- asking to update two specific hardware devices
- testing just those two hardware devices
- stating that only cirrus audio (presumably those two hardware devices) could 
regress

It was fine so far. But then you:
- include 90+ topology files for other devices not mentioned even once in the 
bug.

Do you see the discrepancy and why I'm alarmed? What is in the actual
bits of code that was uploaded is NOT what is stated in this bug. Your
bug is requesting one thing, but doing something else much larger.

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/2106394

Title:
  [SRU] enable cs42l43 and cs35l56 audio on Intel LNL

Status in HWE Next:
  New
Status in alsa-ucm-conf package in Ubuntu:
  Fix Committed
Status in firmware-sof package in Ubuntu:
  Fix Released
Status in linux package in Ubuntu:
  New
Status in linux-firmware package in Ubuntu:
  In Progress
Status in alsa-ucm-conf source package in Noble:
  Fix Committed
Status in firmware-sof source package in Noble:
  Incomplete
Status in linux source package in Noble:
  Won't Fix
Status in linux-firmware source package in Noble:
  Fix Committed
Status in alsa-ucm-conf source package in Oracular:
  Fix Committed
Status in firmware-sof source package in Oracular:
  Incomplete
Status in linux source package in Oracular:
  Fix Committed
Status in linux-firmware source package in Oracular:
  Fix Committed
Status in alsa-ucm-conf source package in Plucky:
  New
Status in firmware-sof source package in Plucky:
  Fix Released
Status in linux source package in Plucky:
  Fix Released
Status in linux-firmware source package in Plucky:
  New

Bug description:
  [Impact]
  No audio input/output for cs42l43 and cs35l56 on Intel LNL of ThinkPad.

  [Fix]
  Add the firmware of cs35l56 and sof-lnl-cs42l43-l0-2ch.tplg
  to enable audio support;
  update alsa-ucm-conf to gain the control of mic/speaker mute LED.

  linux-fimware commit:
  9c46d10f8 cirrus: cs35l56: Add and update firmware for various Cirrus CS35L54 
and CS35L56 laptops

  sof-bin commit:
  e8604e4 Add 2.12 topology binaries for Intel targets

  sof-bin file:
  v2.12.x/sof-ipc4-tplg-v2.12/sof-lnl-cs42l43-l0-2ch.tplg

  alsa-ucm-conf commits:
  9e946d4 sof-soundwire: Add LED support for cs35l56 amplifiers
  79c9e8f sof-soundwire: cs42l43: Drop headset mic from mic mute LED

  [Test]
  Tested on Intel LNL:
  1, hear the sound from 
  $ speaker-test -c 2
  2, make sound and recorded, replay the file:
  $ arecord -f cd test.wav
  $ aplay test.wav
  3, press speaker-mute and mic-mute key, the OSD are shown,
  and the LED is on when it's muted.
  4, plugin headset and restest the steps above.

  [Where problems could occur]
  It may break cirrus audio support.

  Noble/Oracular/Plucky support this platform,  Plucky already got the
  firmware.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hwe-next/+bug/2106394/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to