firmware-sof doesn't have an SRU exception[1] that allows it to add such
bulk changes without a specific process.

This bug here claims to be enabling just "cs42l43 and cs35l56 audio on
Intel LNL", but the commit is far more reaching than that claim.

If I look at the previous update[2], only one topology file was
added[3]: sof-tplg-v2.2.13/sof-rpl-cs42l43-l0.tplg

> It would be better to catch up with upstream to have these configuration 
> which can support more 
> configurations we could be missing in the future.

This rationale is not always true. Such a type of update can also bring
with it other bugs, which would mean a regression for ubuntu stable
release users. See [4] for some examples and arguments in favor of
minimal changes.

Why do you claim that bringing in all those other 90+ topology files is better 
and less risky than updating just the one we need to fix this bug? I'm 
definitely not the expert in this package, but I see a huge amount of changes, 
to other pieces of hardware, and I have to wonder:
- how can we be sure we are not regressing all those other sound cards?
- we are testing just "intel NL", what about all the other changes?
- Why can you claim that this update will not affect other hardware? You state, 
in the bug description: "It may break cirrus audio support.". But I see many 
topology files that don't seem to be limited to "cirrus audio".

What is the risk in updating/adding just the files we need for "cs42l43
and cs35l56 audio on Intel LNL"?


1. https://wiki.ubuntu.com/StableReleaseUpdates#Documentation_for_Special_Cases
2. https://launchpad.net/ubuntu/+source/firmware-sof/2023.12.1-1ubuntu1.4
3. 
https://git.launchpad.net/ubuntu/+source/firmware-sof/commit/?h=ubuntu/noble-devel
4. 
https://documentation.ubuntu.com/sru/en/latest/explanation/requirements/#explanation-minimal

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/2106394

Title:
  [SRU] enable cs42l43 and cs35l56 audio on Intel LNL

Status in HWE Next:
  New
Status in alsa-ucm-conf package in Ubuntu:
  Fix Committed
Status in firmware-sof package in Ubuntu:
  Fix Released
Status in linux package in Ubuntu:
  New
Status in linux-firmware package in Ubuntu:
  In Progress
Status in alsa-ucm-conf source package in Noble:
  Fix Committed
Status in firmware-sof source package in Noble:
  Incomplete
Status in linux source package in Noble:
  Won't Fix
Status in linux-firmware source package in Noble:
  Fix Committed
Status in alsa-ucm-conf source package in Oracular:
  Fix Committed
Status in firmware-sof source package in Oracular:
  Incomplete
Status in linux source package in Oracular:
  Fix Committed
Status in linux-firmware source package in Oracular:
  Fix Committed
Status in alsa-ucm-conf source package in Plucky:
  New
Status in firmware-sof source package in Plucky:
  Fix Released
Status in linux source package in Plucky:
  New
Status in linux-firmware source package in Plucky:
  New

Bug description:
  [Impact]
  No audio input/output for cs42l43 and cs35l56 on Intel LNL of ThinkPad.

  [Fix]
  Add the firmware of cs35l56 and sof-lnl-cs42l43-l0-2ch.tplg
  to enable audio support;
  update alsa-ucm-conf to gain the control of mic/speaker mute LED.

  linux-fimware commit:
  9c46d10f8 cirrus: cs35l56: Add and update firmware for various Cirrus CS35L54 
and CS35L56 laptops

  sof-bin commit:
  e8604e4 Add 2.12 topology binaries for Intel targets

  sof-bin file:
  v2.12.x/sof-ipc4-tplg-v2.12/sof-lnl-cs42l43-l0-2ch.tplg

  alsa-ucm-conf commits:
  9e946d4 sof-soundwire: Add LED support for cs35l56 amplifiers
  79c9e8f sof-soundwire: cs42l43: Drop headset mic from mic mute LED

  [Test]
  Tested on Intel LNL:
  1, hear the sound from 
  $ speaker-test -c 2
  2, make sound and recorded, replay the file:
  $ arecord -f cd test.wav
  $ aplay test.wav
  3, press speaker-mute and mic-mute key, the OSD are shown,
  and the LED is on when it's muted.
  4, plugin headset and restest the steps above.

  [Where problems could occur]
  It may break cirrus audio support.

  Noble/Oracular/Plucky support this platform,  Plucky already got the
  firmware.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hwe-next/+bug/2106394/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to