dhaumann added a comment.

  In D19001#413694 <https://phabricator.kde.org/D19001#413694>, @cullmann wrote:
  
  > This looks reasonable, but could we get some Qt/KDE style CamelCase enum 
values?
  >
  > enum SaveResult {
  >
  >       SAVE_FAILED = 0,
  >       SAVE_NO_PERMS,
  >       SAVE_SUCCESS
  >   };
  
  
  You could even use an enum class:
  
    enum class SaveResult {
        Failed = 0,
        MissingPermissions,
        Success
    };

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19001

To: mgerstner, dhaumann, cullmann, #ktexteditor, chinmoyr, fvogt
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

Reply via email to