cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed.
This looks reasonable, but could we get some Qt/KDE style CamelCase enum values? enum SaveResult { SAVE_FAILED = 0, SAVE_NO_PERMS, SAVE_SUCCESS }; REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19001 To: mgerstner, dhaumann, cullmann, #ktexteditor, chinmoyr, fvogt Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann