----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129275/#review100396 -----------------------------------------------------------
autotests/jobtest.cpp (line 276) <https://git.reviewboard.kde.org/r/129275/#comment67377> int => in autotests/jobtest.cpp (line 288) <https://git.reviewboard.kde.org/r/129275/#comment67379> Strange sentence, it sounds like if it was WriteOnly we wouldn't have to do anything. It would be worse if it was WriteOnly, we'd have to close+reopen. Suggestion: QTemporaryFiles are open in ReadWrite mode, so we don't need to close and reopen, but we need to rewind to the beginning. autotests/jobtest.cpp (line 294) <https://git.reviewboard.kde.org/r/129275/#comment67378> To avoid getting hit by 0==0 here ever again, I would also check that either one is > 0. - David Faure On Oct. 30, 2016, 11:05 a.m., Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129275/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2016, 11:05 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > https://bugs.kde.org/show_bug.cgi?id=368314 seems to be an actual bug in KIO, > rather than a regression in kwalletmanager. I reproduced the bug in a test > case: basically `StoredTransferJob` fails to copy a QTemporaryFile when the > file has been written by a QXmlStreamWriter (destination file is created, but > empty). > > If we write to the temp file using a QTextStreamer instead, everything works > as expected... > > > Diffs > ----- > > autotests/jobtest.h 5687b4a448d26d703d33603e5a0939bc4f8c77b4 > autotests/jobtest.cpp 11bac4d51e97840181aff99fdddb92cdf4db1ba2 > src/core/storedtransferjob.h 82ffe77eec9d37af3b3bad81a3515d31eb5d4e94 > > Diff: https://git.reviewboard.kde.org/r/129275/diff/ > > > Testing > ------- > > jobtest still passes (with one expected failure). > > > Thanks, > > Elvis Angelaccio > >
