> On Sept. 26, 2016, 1:40 p.m., Aleix Pol Gonzalez wrote: > > autotests/dupetest.cpp, line 66 > > <https://git.reviewboard.kde.org/r/129021/diff/1/?file=477536#file477536line66> > > > > It should mark an error if dupes found, no? > > Harald Sitter wrote: > Doesn't QFAIL unwind the stack?
Not if you do it in the right place :D - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129021/#review99526 ----------------------------------------------------------- On Sept. 26, 2016, 2:30 p.m., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129021/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2016, 2:30 p.m.) > > > Review request for KDE Frameworks. > > > Repository: breeze-icons > > > Description > ------- > > run a duplicate detection program on the icon dir trees to detect > duplicated icons which should be symlinked to reduce disk usage > > uses external program since otherwise we'd be needlessly reimplmenting what > that program does (alas, couldn't find a lib) > > > Diffs > ----- > > autotests/CMakeLists.txt 9e3f841d951afb007cba3da79c217e9c2a3e38da > autotests/dupetest.cpp PRE-CREATION > autotests/newlinetest.cpp 355af0c3d0e1ce42c260652e43a00364769661f1 > autotests/symlinktest.cpp 15047ea72f95cbaa4578668e59ad687faa8ae230 > autotests/testdata.h.cmake 476cf9ebf8b45c65e5479e14adcb1ea352e1f24d > autotests/testhelpers.h PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129021/diff/ > > > Testing > ------- > > correctly detects all the nasty dupes > > > Thanks, > > Harald Sitter > >
