----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129021/#review99526 -----------------------------------------------------------
autotests/dupetest.cpp (line 36) <https://git.reviewboard.kde.org/r/129021/#comment66943> `const` missing autotests/dupetest.cpp (line 66) <https://git.reviewboard.kde.org/r/129021/#comment66942> It should mark an error if dupes found, no? - Aleix Pol Gonzalez On Sept. 26, 2016, 1:27 p.m., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129021/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2016, 1:27 p.m.) > > > Review request for KDE Frameworks. > > > Repository: breeze-icons > > > Description > ------- > > run a duplicate detection program on the icon dir trees to detect > duplicated icons which should be symlinked to reduce disk usage > > uses external program since otherwise we'd be needlessly reimplmenting what > that program does (alas, couldn't find a lib) > > > Diffs > ----- > > autotests/CMakeLists.txt 9e3f841d951afb007cba3da79c217e9c2a3e38da > autotests/dupetest.cpp PRE-CREATION > autotests/testdata.h.cmake 476cf9ebf8b45c65e5479e14adcb1ea352e1f24d > > Diff: https://git.reviewboard.kde.org/r/129021/diff/ > > > Testing > ------- > > correctly detects all the nasty dupes > > > Thanks, > > Harald Sitter > >
