----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127572/ -----------------------------------------------------------
Review request for KDE Frameworks, Christoph Feck, David Edmundson, and Ragnar Thomsen. Repository: kwidgetsaddons Description ------- We have an use-case in Ark where the password widget belongs to a vertical layout within a KCollapsibleGroupBox. Without this patch, the strength meter bar takes room even if not visible, resulting in a wasted empty space (see screenshots). Diffs ----- src/knewpasswordwidget.h acd14105fe9f2d3d212a9667be8b05823c2cb4a8 src/knewpasswordwidget.cpp 72748d6b9e9fed979bd75ce856867a7bbf9e2fbd Diff: https://git.reviewboard.kde.org/r/127572/diff/ Testing ------- File Attachments ---------------- Before https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/e6462cad-f2c9-4b11-86f9-e49230072b77__knewpasswordwidget-no-hint.png After https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/9d9b331a-678f-47f0-9335-87c4bfe16204__knewpasswordwidget-size-hint.png Thanks, Elvis Angelaccio
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
