----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115496/#review50149 -----------------------------------------------------------
> Overriding a CMake package like this will just cause all sorts of > headaches later on. I tried to make the same point, but I wasn't believed :). - Stephen Kelly On Feb. 16, 2014, 5:54 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115496/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2014, 5:54 p.m.) > > > Review request for Build System, Extra Cmake Modules and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > Rename CMakePackageConfigHelpers to ECMPackageConfigHelpers > > Overriding a CMake package like this will just cause all sorts of > headaches later on. In this particular case, projects that depended on > CMake 2.8.13 or later (more likely 3.0.0) would fail with a message > about removing the CMakePackageConfigHelpers file, but would have no way > to do that while still using ECM. > > This also renames the configure_package_config_file() macro to > ecm_configure_package_config_file(), so that anything including > CMakePackageConfigHelpers afterwards does not overwrite the macro > unexpectedly. > > For now, we keep a CMakePackageConfigHelpers.cmake file that just wraps > ecm_configure_package_config_file() as configure_package_config_file() > to keep the frameworks building while they are ported. > > > Diffs > ----- > > modules/CMakePackageConfigHelpers.cmake > 5d65e659f7a04d65aeb08fa99569e88dde89acf2 > modules/ECMPackageConfigHelpers.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/115496/diff/ > > > Testing > ------- > > kdesrc-build has got to KIO so far with no problems. > > If KJS includes ECMPackageConfigHelpers and uses > ecm_configure_package_config_file(), both KJS and KI18n configure and build > properly. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
