----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115496/ -----------------------------------------------------------
(Updated Feb. 5, 2014, 5:26 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description (updated) ------- Rename CMakePackageConfigHelpers to ECMPackageConfigHelpers Overriding a CMake package like this will just cause all sorts of headaches later on. In this particular case, projects that depended on CMake 2.8.13 or later (more likely 3.0.0) would fail with a message about removing the CMakePackageConfigHelpers file, but would have no way to do that while still using ECM. Projects that use ECM (and support CMake 2.8.12) will need to be adjusted to include this module by its new name. If necessary, this can be done in two parts: add ECMCMakePackageConfigHelpers, change all the frameworks, remove CMakePackageConfigHelpers. Diffs ----- modules/CMakePackageConfigHelpers.cmake 5d65e659f7a04d65aeb08fa99569e88dde89acf2 modules/ECMSetupVersion.cmake 3a8defd8223e84f338cc297bf19cdfcaf564e5f1 Diff: https://git.reviewboard.kde.org/r/115496/diff/ Testing ------- Using CMake 2.8.12: KI18n build fails if KJS is left unchanged. If it includes ECMPackageConfigHelpers instead of CMakePackageConfigHelpers, both KJS and KI18n configure and build properly. Thanks, Alex Merry
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
