> On Feb. 16, 2014, 5:22 p.m., Albert Astals Cid wrote: > > src/ktranscript.cpp, line 1489 > > <https://git.reviewboard.kde.org/r/115485/diff/3/?file=244386#file244386line1489> > > > > Kill the qdebug (and the one a bit below)?
good catch, thanks - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/#review49941 ----------------------------------------------------------- On Feb. 16, 2014, 6:54 p.m., Kevin Krammer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115485/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2014, 6:54 p.m.) > > > Review request for KDE Frameworks and Chusslove Illich. > > > Repository: ki18n > > > Description > ------- > > Attempt at replacing the KJS dependency with a QtScript, i.e. making ki18n a > tier1 framework. > Needs more testing and likely fixing > > > Diffs > ----- > > CMakeLists.txt 3e099d5 > src/CMakeLists.txt 9e3ce9f > src/ktranscript.cpp c922e91 > > Diff: https://git.reviewboard.kde.org/r/115485/diff/ > > > Testing > ------- > > Unittest runs, but the test script is very minimal and would need to be > extendedb by someone who understands the scripting requirements. > There is also a weird crash at test shutdown, in QThreadStorage. As far as I > can tell I did not change anything related to threads though. > > > Thanks, > > Kevin Krammer > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
