> On Feb. 5, 2014, 3:51 p.m., Aurélien Gâteau wrote: > > Wow, great work! I attempted doing this some time ago, and all I managed to > > produce was two unit tests :). Looks good to me and works fine here. Just > > two (really minor) nitpicks.
Thanks :) Good to hear that it works properly, I guess we should try to increase the test coverage before we merge a change like that. I'll see what I can contribute to that effort but ideally someone who really understands how this is used can contribute a couple of advanced test cases :) - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/#review49036 ----------------------------------------------------------- On Feb. 5, 2014, 4:08 p.m., Kevin Krammer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115485/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2014, 4:08 p.m.) > > > Review request for KDE Frameworks and Chusslove Illich. > > > Repository: ki18n > > > Description > ------- > > Attempt at replacing the KJS dependency with a QtScript, i.e. making ki18n a > tier1 framework. > Needs more testing and likely fixing > > > Diffs > ----- > > CMakeLists.txt 3e099d5 > src/CMakeLists.txt 55fa512 > src/ktranscript.cpp 2fde5c2 > > Diff: https://git.reviewboard.kde.org/r/115485/diff/ > > > Testing > ------- > > Unittest runs, but the test script is very minimal and would need to be > extendedb by someone who understands the scripting requirements. > There is also a weird crash at test shutdown, in QThreadStorage. As far as I > can tell I did not change anything related to threads though. > > > Thanks, > > Kevin Krammer > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
