kossebau added inline comments.

INLINE COMMENTS

> kossebau wrote in ECMConfiguredInstall.cmake:62
> These strings (besides the last obviously) should get added with whitespace 
> suffix, to handle the case where multiple are added, no? Not yet got to 
> test/run things, just guessing by reading code.

Actually, _configure_args could be a list  (starting with empty, not "") and 
one would do list(APPEND). And cmake would then properly resolve that var when 
used with configure_file I would expect (to be tested).

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D28355

To: davidedmundson
Cc: kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, 
GB_2, bencreasy, michaelh, ngraham, bruns

Reply via email to