davidedmundson added a comment.

  I agree with almost all those suggestions. Though it's a lot more complex, so 
I might need some help with some of that.
  
  As for intended usages, it came up on: D28305 
<https://phabricator.kde.org/D28305> for a lot of .service files with a binary 
location that needs to be derived at configure time. 
  But it seemed if I made it generic enough it was a pattern that showed up in 
other locations as shown by porting remaining bits of plasma-workspace: D28422 
<https://phabricator.kde.org/D28422>

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D28355

To: davidedmundson
Cc: kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, 
GB_2, bencreasy, michaelh, ngraham, bruns

Reply via email to