El dijous, 21 de maig de 2020, a les 6:27:25 CEST, Ivan Romanov va escriure: > > El dimecres, 20 de maig de 2020, a les 6:07:28 CEST, Ivan Romanov va > > escriure: > > > IANA doesn't provide any licesnse info. > > > > If there's no license info, that means that we can't ship it. Please > > remove it from \ our repositories ASAP and think twice before adding > > things we don't know the license \ of. > > > > > Anyway how to apply license to > > > CSV file? I not sure that CSV format supports comments. Also seems > > > now I must add another script to modify downloaded CSV file or add > > > instruction how to modify this file to satisfy all policies. > > > > You mean the CSV from IANA is not the direct input of the script? > > > > Oh I see you already removed the script, you keep not doing Merge > > Requests even if i \ keep asking you. > > What wrong with direct commits? I didn't big changes only bug fixes.
Given that there's people willing to review your patches, they should be reviewed, more eyes is always a good thing. "only bugfixes" have broken lots of code before. Also it's very easy to break all the checks that I added in Continuous Integration regarding clazy and clang-tidy. Cheers, Albert > > > Not cool. > > > > Albert > > > > > > > > > El dimarts, 19 de maig de 2020, a les 17:12:16 CEST, Ivan Romanov > > > > va escriure: > > > > > Tried to fix. > > > > > https://invent.kde.org/libraries/qca/-/commit/b69aab24315cc6821cc1da928e95cc0a4c42e311 > > > > > Now enough good? > > > > > > > > Not sure, what's the license of the csv file? > > > > > > > > Given it comes from iana, are we sure we can distribute it? > > > > > > > > Cheers, > > > > Albert > > > > > > > > > > > > > > On Tue, 19 May 2020 00:09:32 +0200 > > > > > Albert Astals Cid <aa...@kde.org> wrote: > > > > > > > > > > > El dilluns, 18 de maig de 2020, a les 23:55:11 CEST, Johan > > > > > > Ouwerkerk va escriure: > > > > > > > On Mon, May 18, 2020 at 8:59 PM Ivan Romanov > > > > > > > <driz...@zoho.eu> wrote: > > > > > > > > > > > > > > > > Hello. > > > > > > > > > > > > > > > > Today I added generated file to QCA repo. This commit > > > > > > > > https://invent.kde.org/libraries/qca/-/commit/cf929ce541b48e36a54691a37b31211d17334bf7. > > > > > > > > And got such email mesage: The files marked with a * at > > > > > > > > the end have a non valid license. Please read: > > > > > > > > https://community.kde.org/Policies/Licensing_Policy and > > > > > > > > use the headers which are listed at that page. > > > > > > > > > > > > > > > > So which header/license I should use in my case? > > > > > > > > > > > > > > I'd use the same license as for the main project -- but > > > > > > > someone else might have a better reasoned opinion than just > > > > > > > "that would make sense to me" ;) > > > > > > > > > > > > > > However looking at your particular commit I notice a few > > > > > > > things: > > > > > > > > > > > > > > 2. The actual source (CSV) not being committed (judging by > > > > > > > the diff) > > > > > > > > > > > > Yes, that's not acceptable. > > > > > > > > > > > > How are we supposed to run the script again? > > > > > > > > > > > > Cheers, > > > > > > Albert > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
