> On Aug. 29, 2017, 9:03 p.m., Kai Uwe Broulik wrote: > > src/file/fileindexerconfig.cpp, line 173 > > <https://git.reviewboard.kde.org/r/129349/diff/3-4/?file=487422#file487422line173> > > > > You sure this doesn't crash? I've seen crashes when you directly chain > > a Ref to another method.
Where do you see a chained ref? - Stefan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129349/#review103663 ----------------------------------------------------------- On Aug. 24, 2017, 5:48 a.m., Christian Ehrlicher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129349/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2017, 5:48 a.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > Use the new QStringRef class to avoid creation of temporary QString objects. > Since every filename is sent through > FileIndexerConfig::shouldFileBeIndexed(), I think this is a good optimization > although now there are two functions for > FileIndexerConfig::shouldFileBeIndexed() and RegExpCache::exactMatch() - one > with QString and one with QStringRef ... > > > Diffs > ----- > > src/engine/queryparser.cpp 9c3a4b60 > src/file/fileindexerconfig.h e2466bdd > src/file/fileindexerconfig.cpp 0e4f4c45 > src/file/modifiedfileindexer.cpp d1f5011b > src/file/newfileindexer.cpp 7e196229 > src/file/regexpcache.h 60d370de > src/file/regexpcache.cpp 61f07d61 > src/file/xattrindexer.cpp 3daecef6 > src/kioslaves/timeline/timelinetools.cpp 26e44ee8 > > Diff: https://git.reviewboard.kde.org/r/129349/diff/ > > > Testing > ------- > > > Thanks, > > Christian Ehrlicher > >
