----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129349/ -----------------------------------------------------------
(Updated Dec. 13, 2016, 7:39 p.m.) Review request for Baloo. Changes ------- Changed the last issue to use QVector<QStringRef> and QRegularExpression instead QRegExp (tested it with local testcase). Repository: baloo Description ------- Use the new QStringRef class to avoid creation of temporary QString objects. Since every filename is sent through FileIndexerConfig::shouldFileBeIndexed(), I think this is a good optimization although now there are two functions for FileIndexerConfig::shouldFileBeIndexed() and RegExpCache::exactMatch() - one with QString and one with QStringRef ... Diffs (updated) ----- src/engine/queryparser.cpp d096bf3 src/file/fileindexerconfig.h 10eacd5 src/file/fileindexerconfig.cpp 0e4f4c4 src/file/modifiedfileindexer.cpp d1f5011 src/file/newfileindexer.cpp 7e19622 src/file/regexpcache.h 60d370d src/file/regexpcache.cpp 61f07d6 src/file/xattrindexer.cpp 3daecef src/kioslaves/tags/kio_tags.cpp de2e6d7 src/kioslaves/timeline/timelinetools.cpp 26e44ee Diff: https://git.reviewboard.kde.org/r/129349/diff/ Testing ------- Thanks, Christian Ehrlicher
