> On March 3, 2016, 10:24 p.m., Aleix Pol Gonzalez wrote: > > cmake/modules/KDE4Macros.cmake, line 1003 > > <https://git.reviewboard.kde.org/r/127264/diff/1/?file=447921#file447921line1003> > > > > Without the conditionals, the code would work just as well.
Unless you have a CMake so old that said policy doesn't exist. For eg. on Debian stable :) - Rohan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127264/#review93107 ----------------------------------------------------------- On March 3, 2016, 6:28 p.m., Rohan Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127264/ > ----------------------------------------------------------- > > (Updated March 3, 2016, 6:28 p.m.) > > > Review request for kdelibs and David Faure. > > > Repository: kdelibs > > > Description > ------- > > This follows the same idea from 826a5ff3278f492a99ac6827614e1d0ca40a45e8 > > > Diffs > ----- > > cmake/modules/KDE4Macros.cmake 5bb2ffa > > Diff: https://git.reviewboard.kde.org/r/127264/diff/ > > > Testing > ------- > > > Thanks, > > Rohan Garg > >