----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127264/#review93107 -----------------------------------------------------------
cmake/modules/KDE4Macros.cmake (line 1003) <https://git.reviewboard.kde.org/r/127264/#comment63484> Without the conditionals, the code would work just as well. - Aleix Pol Gonzalez On March 3, 2016, 1:58 p.m., Rohan Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127264/ > ----------------------------------------------------------- > > (Updated March 3, 2016, 1:58 p.m.) > > > Review request for kdelibs and David Faure. > > > Repository: kdelibs > > > Description > ------- > > This follows the same idea from 826a5ff3278f492a99ac6827614e1d0ca40a45e8 > > > Diffs > ----- > > cmake/modules/KDE4Macros.cmake 5bb2ffa > > Diff: https://git.reviewboard.kde.org/r/127264/diff/ > > > Testing > ------- > > > Thanks, > > Rohan Garg > >
