----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113866/#review45846 -----------------------------------------------------------
Ship it! Looks good, please push to KDE 4.12, I'll merge upwards. - David Faure On Dec. 16, 2013, 6:33 p.m., Stefan Brüns wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113866/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2013, 6:33 p.m.) > > > Review request for kdelibs and Frank Reininghaus. > > > Bugs: 320006 > http://bugs.kde.org/show_bug.cgi?id=320006 > > > Repository: kdelibs > > > Description > ------- > > Only iterate over element nodes, and filter on <folder> tag. > > findFirstChild/nextSibling might return a node which is not an QDomElement. > toElement will return NULL and accessing it will crash. > > Possible fix for 320006 > > > Diffs > ----- > > kio/bookmarks/kbookmark.cc 8459a02 > > Diff: http://git.reviewboard.kde.org/r/113866/diff/ > > > Testing > ------- > > None > > > Thanks, > > Stefan Brüns > >
