> On Nov. 26, 2013, 4:34 p.m., David Faure wrote: > > kio/bookmarks/kbookmark.cc, line 251 > > <http://git.reviewboard.kde.org/r/113866/diff/1/?file=214134#file214134line251> > > > > firstChildElement returns a QDomElement, you should declare the > > variable as such, to avoid the toElement() call below.
Which branches should this be pushed to? - Stefan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113866/#review44510 ----------------------------------------------------------- On Dec. 16, 2013, 6:33 p.m., Stefan Brüns wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113866/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2013, 6:33 p.m.) > > > Review request for kdelibs and Frank Reininghaus. > > > Bugs: 320006 > http://bugs.kde.org/show_bug.cgi?id=320006 > > > Repository: kdelibs > > > Description > ------- > > Only iterate over element nodes, and filter on <folder> tag. > > findFirstChild/nextSibling might return a node which is not an QDomElement. > toElement will return NULL and accessing it will crash. > > Possible fix for 320006 > > > Diffs > ----- > > kio/bookmarks/kbookmark.cc 8459a02 > > Diff: http://git.reviewboard.kde.org/r/113866/diff/ > > > Testing > ------- > > None > > > Thanks, > > Stefan Brüns > >
