----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/#review41907 -----------------------------------------------------------
Good job! I think this can go in, but I'd like someone else approve tier1/kcoreaddons/src/lib/io/kdirwatch.cpp <http://git.reviewboard.kde.org/r/113298/#comment30577> I think this could be better as uncommenting the variable and using Q_UNUSED (and moving the * to the right too), but that's minor tier1/kcoreaddons/src/lib/io/kdirwatch_p.h <http://git.reviewboard.kde.org/r/113298/#comment30578> why did you choose "_path" instead of just "path"? - Martin Klapetek On Oct. 17, 2013, 7:05 p.m., Nicolás Alvarez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113298/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2013, 7:05 p.m.) > > > Review request for KDE Frameworks and kdelibs. > > > Repository: kdelibs > > > Description > ------- > > KDirWatch code style: cleanup whitespace. > > The KDirWatch code had *lots* of "( foo )" and inconsistent indentation and > alignment, including a few tabs(!). This is a full cleanup of it. > > I appreciate any feedback; if I "fixed" something that didn't need fixing, or > if you see more whitespace errors that I didn't fix, or if I should push this > to master too, or if I should leave the damn thing alone and discard the > review :) > > This file is also lacking braces for single-line conditionals and loops; I'll > fix that in a separate commit for easier reviewing. It's also mixing 2-space > and 4-space indentations, but changing everything to 4 spaces (as the kdelibs > coding style says) seemed too intrusive. Perhaps I should change the few > 4-space indentations into 2-space for consistency? > > > Diffs > ----- > > tier1/kcoreaddons/src/lib/io/kdirwatch_p.h > 442d6497b704c179adc13dbb25e450554d31554d > tier1/kcoreaddons/src/lib/io/kdirwatch.cpp > e4f45441d5ed68e3e34ae2bd68e16fd3dc46656a > tier1/kcoreaddons/src/lib/io/kdirwatch.h > 7f6ca8ce83426c81a6336514c247aa9d115ec59e > > Diff: http://git.reviewboard.kde.org/r/113298/diff/ > > > Testing > ------- > > Still compiles :) > > > Thanks, > > Nicolás Alvarez > >
