> On Oct. 17, 2013, 4:46 a.m., Martin Klapetek wrote: > > tier1/kcoreaddons/src/lib/io/kdirwatch_p.h, line 183 > > <http://git.reviewboard.kde.org/r/113298/diff/1/?file=202295#file202295line183> > > > > Spaces inside -> "KDirWatch *, bool"
I added the parameter names to kdirwatch_p.h too. > On Oct. 17, 2013, 4:46 a.m., Martin Klapetek wrote: > > tier1/kcoreaddons/src/lib/io/kdirwatch.cpp, line 720 > > <http://git.reviewboard.kde.org/r/113298/diff/1/?file=202294#file202294line720> > > > > Indent one level more (should be 8 spaces at this level)....actually > > this whole file seems to have wrong indentation, so maybe fix all of that? I'll probably fix indentation in a separate commit for easier reviewing. - Nicolás ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/#review41860 ----------------------------------------------------------- On Oct. 17, 2013, 4 p.m., Nicolás Alvarez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113298/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2013, 4 p.m.) > > > Review request for KDE Frameworks and kdelibs. > > > Repository: kdelibs > > > Description > ------- > > KDirWatch code style: cleanup whitespace. > > The KDirWatch code had *lots* of "( foo )" and inconsistent indentation and > alignment, including a few tabs(!). This is a full cleanup of it. > > I appreciate any feedback; if I "fixed" something that didn't need fixing, or > if you see more whitespace errors that I didn't fix, or if I should push this > to master too, or if I should leave the damn thing alone and discard the > review :) > > This file is also lacking braces for single-line conditionals and loops; I'll > fix that in a separate commit for easier reviewing. It's also mixing 2-space > and 4-space indentations, but changing everything to 4 spaces (as the kdelibs > coding style says) seemed too intrusive. Perhaps I should change the few > 4-space indentations into 2-space for consistency? > > > Diffs > ----- > > tier1/kcoreaddons/src/lib/io/kdirwatch.h > 7f6ca8ce83426c81a6336514c247aa9d115ec59e > tier1/kcoreaddons/src/lib/io/kdirwatch.cpp > e4f45441d5ed68e3e34ae2bd68e16fd3dc46656a > tier1/kcoreaddons/src/lib/io/kdirwatch_p.h > 442d6497b704c179adc13dbb25e450554d31554d > > Diff: http://git.reviewboard.kde.org/r/113298/diff/ > > > Testing > ------- > > Still compiles :) > > > Thanks, > > Nicolás Alvarez > >
