> On Sept. 8, 2012, 12:11 p.m., Oswald Buddenhagen wrote: > > ksmserver/screenlocker/DESIGN, line 13 > > <http://git.reviewboard.kde.org/r/106124/diff/3/?file=83586#file83586line13> > > > > "xembe[]ds" > > > > this sounds funny. the saver window is on top of the greeter? > > Marco Martin wrote: > yes, they're basically mutually exclusuve, because the greeter is a > fullscreen window with a wallpaper now, and is the default intended way, the > screensaver is disabled by default. (in the future beside unlocker there may > be other stuff like notifications marked as not privacy sensitive) > > right now, the screensaver goes away after mouse move and gets back after > a minute (or user pressing esc) something to make it more intuitive on how to > get it back could be a "cancel" button in the locker present if the > screensaver is enabled. > > Oswald Buddenhagen wrote: > this should go into the file. > > what about the (unsafe) screenshot distortion category of savers? also, > most simple savers don't make full repaints, so after hiding the window one > has to fully restore the contents before continuing. do you handle that? > > Marco Martin wrote: > at the moment is not managed.. > it may be either a screenshot of the desktop as usual (by making the > screensaver window start before the locker one) > or a render of the locker window, in this case they would even become > secure
Is the greeter *always* mapped before the "saver" is run? In case just delay it - run the "saver", ensure an XSync, pray the "saver" has taken the desired screendump to operate on - then map the greeter below the "saver". > also, most simple savers don't make full repaints, so after hiding the window > one has to fully restore the contents before continuing Humm? On a map/exposure event the window should repost it's content - do you have an example xss hack? Alternatively one could just stack the "saver" below the greeter (and restack later on), but w/o compositor that does hardly differ from the unmap/map case. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106124/#review18681 ----------------------------------------------------------- On Sept. 19, 2012, 4:57 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106124/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2012, 4:57 p.m.) > > > Review request for KDE Runtime and Martin Gräßlin. > > > Description > ------- > > this is the finalization of the old "screenlocker" branch in workspace: > the screen saver goes away (discussed at the time, about one year ago) and > the screen locker gets managed by ksmserver, with a greeter that has the ui > dine in qml. > The same qml ui gets loaded by the plasma based greeter when the "allow > widgets on screen locker" is enabled. > the screensaver kcm is now called "Screen locker" and is way simpler, the > screen saver chooser is gone from it. > > > Diffs > ----- > > kcontrol/screensaver/CMakeLists.txt e4dcc3a > kcontrol/screensaver/screensaver.ui 0ad5cd8 > kcontrol/screensaver/scrnsave.h 7c8deba > kcontrol/screensaver/scrnsave.cpp c0507d4 > krunner/CMakeLists.txt 21eac6f > krunner/dbus/org.freedesktop.ScreenSaver.xml 5efd943 > krunner/dbus/org.kde.screensaver.xml e700b88 > krunner/kcfg/kscreensaversettings.kcfg c8f76f3 > krunner/kcfg/kscreensaversettings.kcfgc af9133d > krunner/krunnerapp.h 040198d > krunner/krunnerapp.cpp eea6220 > krunner/lock/CMakeLists.txt cf9a67e > krunner/lock/autologout.h 0c444050 > krunner/lock/autologout.cc c86e29a > krunner/lock/config-krunner-lock.h.cmake 7bfdfd6 > krunner/lock/kscreenlocker.notifyrc b3e87c8 > krunner/lock/lockdlg.h f25e55f > krunner/lock/lockdlg.cc 14a9b34 > krunner/lock/lockprocess.h 8b6d9a8 > krunner/lock/lockprocess.cc 65c7f1d > krunner/lock/main.h 8a60353 > krunner/lock/main.cc 7b41024 > krunner/main.cpp 84a547b > krunner/screensaver/saverengine.h 3384d4a > krunner/screensaver/saverengine.cpp 4d90faa > krunner/screensaver/xautolock.h 3db3233 > krunner/screensaver/xautolock.cpp 7124215 > krunner/screensaver/xautolock_c.h 3b82f5c > krunner/screensaver/xautolock_diy.c b9df2f8 > krunner/screensaver/xautolock_engine.c d6d0cf5 > ksmserver/CMakeLists.txt 5f0fd34 > ksmserver/config-ksmserver.h.cmake 933da35 > ksmserver/ksmserver_shortcuts.upd 04b4118 > ksmserver/main.cpp 430a61a > ksmserver/screenlocker/CMakeLists.txt PRE-CREATION > ksmserver/screenlocker/DESIGN PRE-CREATION > ksmserver/screenlocker/Messages.sh PRE-CREATION > ksmserver/screenlocker/autologout.h PRE-CREATION > ksmserver/screenlocker/autologout.cpp PRE-CREATION > ksmserver/screenlocker/data/CMakeLists.txt PRE-CREATION > ksmserver/screenlocker/data/force_krunner_lock_shortcut_unreg.cpp > PRE-CREATION > ksmserver/screenlocker/data/kscreenlocker_locksession-shortcut.upd > PRE-CREATION > ksmserver/screenlocker/dbus/org.freedesktop.ScreenSaver.xml PRE-CREATION > ksmserver/screenlocker/dbus/org.kde.screensaver.xml PRE-CREATION > ksmserver/screenlocker/greeter/CMakeLists.txt PRE-CREATION > ksmserver/screenlocker/greeter/Messages.sh PRE-CREATION > ksmserver/screenlocker/greeter/greeter.h PRE-CREATION > ksmserver/screenlocker/greeter/greeter.cpp PRE-CREATION > ksmserver/screenlocker/greeter/greeterapp.h PRE-CREATION > ksmserver/screenlocker/greeter/greeterapp.cpp PRE-CREATION > ksmserver/screenlocker/greeter/main.cpp PRE-CREATION > ksmserver/screenlocker/greeter/screensaverwindow.h PRE-CREATION > ksmserver/screenlocker/greeter/screensaverwindow.cpp PRE-CREATION > ksmserver/screenlocker/greeter/sessions.h PRE-CREATION > ksmserver/screenlocker/greeter/sessions.cpp PRE-CREATION > > ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml > PRE-CREATION > > ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/SessionSwitching.qml > PRE-CREATION > > ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/main.qml > PRE-CREATION > > ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/metadata.desktop > PRE-CREATION > ksmserver/screenlocker/interface.h PRE-CREATION > ksmserver/screenlocker/interface.cpp PRE-CREATION > ksmserver/screenlocker/kcfg/kscreensaversettings.kcfg PRE-CREATION > ksmserver/screenlocker/kcfg/kscreensaversettings.kcfgc PRE-CREATION > ksmserver/screenlocker/kscreenlocker.notifyrc PRE-CREATION > ksmserver/screenlocker/ksldapp.h PRE-CREATION > ksmserver/screenlocker/ksldapp.cpp PRE-CREATION > ksmserver/screenlocker/lockwindow.h PRE-CREATION > ksmserver/screenlocker/lockwindow.cpp PRE-CREATION > ksmserver/server.h 8e54221 > ksmserver/server.cpp 7073fc9 > ksmserver/shutdown.cpp 6f298ec > libs/kdm/kgreet_classic.cpp 691d238 > plasma/desktop/applets/kickoff/CMakeLists.txt 4b0d32a > plasma/generic/containmentactions/contextmenu/CMakeLists.txt 5433294 > plasma/generic/runners/sessions/CMakeLists.txt 1b8292c > plasma/screensaver/shell/BackgroundDialog.ui d6d2df7 > plasma/screensaver/shell/CMakeLists.txt 8ea4504 > plasma/screensaver/shell/backgrounddialog.cpp 1357a50 > plasma/screensaver/shell/main.cpp a1ae939 > plasma/screensaver/shell/plasmaapp.h 33137c2 > plasma/screensaver/shell/plasmaapp.cpp ade6c68 > plasma/screensaver/shell/savercorona.h 794e50c > plasma/screensaver/shell/savercorona.cpp 6f83859 > plasma/screensaver/shell/saverview.h 8500e47 > plasma/screensaver/shell/saverview.cpp b6a709e > powerdevil/daemon/CMakeLists.txt 35a4fd4 > startkde.cmake 9adc6f2 > > Diff: http://git.reviewboard.kde.org/r/106124/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
