----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106124/#review18681 -----------------------------------------------------------
ksmserver/main.cpp <http://git.reviewboard.kde.org/r/106124/#comment14764> "starts the session in locked mode"? ksmserver/screenlocker/DESIGN <http://git.reviewboard.kde.org/r/106124/#comment14768> you may also want to mention: - the role of kwin (there seems to be "window marking", which is consistent with what we discussed back then) - the security in regard to the saver's stability (well, it's pretty obvious: as it is in the session manager now, a crashing locker will just crash the session, which is kinda secure by definition). ksmserver/screenlocker/DESIGN <http://git.reviewboard.kde.org/r/106124/#comment14765> "[each] screen" ksmserver/screenlocker/DESIGN <http://git.reviewboard.kde.org/r/106124/#comment14766> "xembe[]ds" this sounds funny. the saver window is on top of the greeter? ksmserver/screenlocker/DESIGN <http://git.reviewboard.kde.org/r/106124/#comment14767> "It instantiates a Plasma scene, a View, and a Containment" ksmserver/screenlocker/greeter/greeter.h <http://git.reviewboard.kde.org/r/106124/#comment14769> but this really is my class (the contents of it, anyway). ;) while this is no copyright, it's just counterproductive to claim the wrong author. ksmserver/screenlocker/greeter/main.cpp <http://git.reviewboard.kde.org/r/106124/#comment14770> this "summary" actually doesn't make sense after this code moved. i suppose this applies to several other files. ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml <http://git.reviewboard.kde.org/r/106124/#comment14771> not sure about the kde policy, but in qt extra empty lines are frowned upon. plasma/screensaver/shell/CMakeLists.txt <http://git.reviewboard.kde.org/r/106124/#comment14772> indentation plasma/screensaver/shell/plasmaapp.cpp <http://git.reviewboard.kde.org/r/106124/#comment14773> you shouldn't "eat" the empty line. - Oswald Buddenhagen On Sept. 4, 2012, 3:23 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106124/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2012, 3:23 p.m.) > > > Review request for KDE Runtime and Martin Gräßlin. > > > Description > ------- > > this is the finalization of the old "screenlocker" branch in workspace: > the screen saver goes away (discussed at the time, about one year ago) and > the screen locker gets managed by ksmserver, with a greeter that has the ui > dine in qml. > The same qml ui gets loaded by the plasma based greeter when the "allow > widgets on screen locker" is enabled. > the screensaver kcm is now called "Screen locker" and is way simpler, the > screen saver chooser is gone from it. > > > Diffs > ----- > > krunner/screensaver/xautolock_c.h 3b82f5c > krunner/screensaver/xautolock.h 3db3233 > krunner/screensaver/xautolock.cpp 7124215 > krunner/screensaver/saverengine.cpp 4d90faa > krunner/screensaver/saverengine.h 3384d4a > krunner/main.cpp 84a547b > krunner/lock/main.h 8a60353 > krunner/lock/main.cc 7b41024 > krunner/lock/lockprocess.h 8b6d9a8 > krunner/lock/lockprocess.cc 65c7f1d > krunner/lock/lockdlg.h f25e55f > krunner/lock/lockdlg.cc 14a9b34 > krunner/lock/config-krunner-lock.h.cmake 7bfdfd6 > krunner/lock/kscreenlocker.notifyrc 14e37ec > krunner/lock/autologout.h 0c444050 > krunner/lock/autologout.cc c86e29a > krunner/kcfg/kscreensaversettings.kcfgc af9133d > krunner/krunnerapp.h 040198d > krunner/krunnerapp.cpp eea6220 > krunner/lock/CMakeLists.txt cf9a67e > krunner/dbus/org.kde.screensaver.xml e700b88 > krunner/kcfg/kscreensaversettings.kcfg c8f76f3 > krunner/dbus/org.freedesktop.ScreenSaver.xml 5efd943 > krunner/CMakeLists.txt 21eac6f > kcontrol/screensaver/scrnsave.h 7c8deba > kcontrol/screensaver/scrnsave.cpp c0507d4 > kcontrol/screensaver/CMakeLists.txt e4dcc3a > kcontrol/screensaver/screensaver.ui 0ad5cd8 > startkde.cmake 36f23f1 > powerdevil/daemon/CMakeLists.txt 35a4fd4 > plasma/screensaver/shell/saverview.h 8500e47 > plasma/screensaver/shell/saverview.cpp b6a709e > plasma/screensaver/shell/main.cpp a1ae939 > plasma/screensaver/shell/plasmaapp.h 33137c2 > plasma/screensaver/shell/plasmaapp.cpp ade6c68 > plasma/screensaver/shell/savercorona.h 794e50c > plasma/screensaver/shell/savercorona.cpp 6f83859 > plasma/screensaver/shell/backgrounddialog.cpp 1357a50 > plasma/screensaver/shell/CMakeLists.txt 8ea4504 > plasma/generic/runners/sessions/CMakeLists.txt 1b8292c > plasma/screensaver/shell/BackgroundDialog.ui d6d2df7 > ksmserver/server.h 8e54221 > ksmserver/server.cpp 7073fc9 > ksmserver/shutdown.cpp 6f298ec > plasma/desktop/applets/kickoff/CMakeLists.txt 4b0d32a > plasma/generic/containmentactions/contextmenu/CMakeLists.txt 5433294 > ksmserver/screenlocker/lockwindow.h PRE-CREATION > ksmserver/screenlocker/lockwindow.cpp PRE-CREATION > ksmserver/screenlocker/ksldapp.cpp PRE-CREATION > ksmserver/screenlocker/ksldapp.h PRE-CREATION > ksmserver/screenlocker/kcfg/kscreensaversettings.kcfg PRE-CREATION > ksmserver/screenlocker/kcfg/kscreensaversettings.kcfgc PRE-CREATION > ksmserver/screenlocker/kscreenlocker.notifyrc PRE-CREATION > ksmserver/screenlocker/interface.cpp PRE-CREATION > ksmserver/screenlocker/interface.h PRE-CREATION > > ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/metadata.desktop > PRE-CREATION > > ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/main.qml > PRE-CREATION > > ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/SessionSwitching.qml > PRE-CREATION > > ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml > PRE-CREATION > ksmserver/screenlocker/greeter/sessions.cpp PRE-CREATION > ksmserver/screenlocker/greeter/sessions.h PRE-CREATION > ksmserver/screenlocker/greeter/main.cpp PRE-CREATION > ksmserver/screenlocker/greeter/screensaverwindow.h PRE-CREATION > ksmserver/screenlocker/greeter/screensaverwindow.cpp PRE-CREATION > ksmserver/screenlocker/greeter/greeterapp.h PRE-CREATION > ksmserver/screenlocker/greeter/greeterapp.cpp PRE-CREATION > krunner/screensaver/xautolock_engine.c d6d0cf5 > ksmserver/CMakeLists.txt 5f0fd34 > ksmserver/config-ksmserver.h.cmake 933da35 > ksmserver/main.cpp 430a61a > ksmserver/screenlocker/CMakeLists.txt PRE-CREATION > ksmserver/screenlocker/DESIGN PRE-CREATION > ksmserver/screenlocker/Messages.sh PRE-CREATION > ksmserver/screenlocker/autologout.h PRE-CREATION > ksmserver/screenlocker/autologout.cpp PRE-CREATION > ksmserver/screenlocker/data/CMakeLists.txt PRE-CREATION > ksmserver/screenlocker/data/force_krunner_lock_shortcut_unreg.cpp > PRE-CREATION > ksmserver/screenlocker/data/kscreenlocker_locksession-shortcut.upd > PRE-CREATION > ksmserver/screenlocker/dbus/org.freedesktop.ScreenSaver.xml PRE-CREATION > ksmserver/screenlocker/dbus/org.kde.screensaver.xml PRE-CREATION > ksmserver/screenlocker/greeter/CMakeLists.txt PRE-CREATION > ksmserver/screenlocker/greeter/Messages.sh PRE-CREATION > ksmserver/screenlocker/greeter/greeter.h PRE-CREATION > ksmserver/screenlocker/greeter/greeter.cpp PRE-CREATION > krunner/screensaver/xautolock_diy.c b9df2f8 > > Diff: http://git.reviewboard.kde.org/r/106124/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
