https://bugs.kde.org/show_bug.cgi?id=492187
--- Comment #7 from Waqar Ahmed <waqar....@gmail.com> --- The separator color should be coming from the "editor color theme". Separator color is used for the line between LineNumber area and editor area. But it seems like its dark in your case so it doesn't really work. I will try to use a variant foreground color of instead, seems to work much better. > I still like the idea of having the widget background be a slightly different > color than the code editor background, but maybe that's just me. I wouldn't > have reopened this for nitpicky subjective stuff like this of course. I > probably shouldn't be the sole source of input on the LSP widget design, just > because I happen to be the only person filing bug reports about it. :-) That is not a bad idea. The problem here is finding the "right" color which works for all themes. That part is not easy. VSCode does this by having dedicated colors for things like this, so if the color is bad, blame it on the theme. I tried to use lightened/darkened background color variants but didn't get too far (but I also didn't try very hard tbh). See my new commit (that will land soon). If you want to help with something like that, it will give you a good idea. We also have contrast helpers in KGuiAddons library that can probably be utilized for finding a good enough match. ---- For the extra padding or margins around headers, its doable if I look at the api. One needs to iterate over all the blocks in the document and find the ones which have a headingLevel() and then change their blockformat to have a block margin. I would encourage you to make an MR, can help finding the right APIs if you want. :) Increasing padding in general should also be doable via setDocumentMargins I think. -- You are receiving this mail because: You are watching all bug changes.
