https://bugs.kde.org/show_bug.cgi?id=492187
Adam Fontenot <adam.m.fontenot+...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #172953|0 |1
is obsolete| |
--- Comment #6 from Adam Fontenot <adam.m.fontenot+...@gmail.com> ---
Created attachment 174110
--> https://bugs.kde.org/attachment.cgi?id=174110&action=edit
screenshot showing appearance of lsp plugin widget as of d84009c4
Thanks for working on this, it looks a lot better to me!
I'm reopening because I think one specific thing isn't really addressed, which
is the insufficient contrast of the widget border. Maybe this is just a quirk
of the theme I'm using, but I think it might actually be worse after the
changes? See attached screenshot.
Probably important to note that I'm not using my global color scheme in Kate. I
use a global light theme, but I use Catppuccin Frappe Flamingo as my Kate
window color scheme, and Catppuccin Macchiato as the editor color theme
(slightly darker alternative, for more contrast). These themes can be found
here: https://github.com/catppuccin/kde
I mention that just in case the separator color is being taken from e.g. the
global light theme, and is inappropriate for the much darker editor color
theme.
-----
I also think it would be very nice to increase the spacing around header "#"
elements slightly if possible, and I'd also consider increasing the padding on
the widget itself so that the text in the widget is given a bit more distance
from surrounding code.
I still like the idea of having the widget background be a slightly different
color than the code editor background, but maybe that's just me. I wouldn't
have reopened this for nitpicky subjective stuff like this of course. I
probably shouldn't be the sole source of input on the LSP widget design, just
because I happen to be the only person filing bug reports about it. :-)
--
You are receiving this mail because:
You are watching all bug changes.
