https://bugs.kde.org/show_bug.cgi?id=482001
Igor Kushnir <igor...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Version Fixed In| |5.15.240800
Resolution|--- |FIXED
Latest Commit| |https://invent.kde.org/kdev
| |elop/kdevelop/-/commit/0587
| |8f92e82424df23a4e6e3c6a2988
| |3fbbedf4b
--- Comment #2 from Igor Kushnir <igor...@gmail.com> ---
Git commit 05878f92e82424df23a4e6e3c6a29883fbbedf4b by Igor Kushnir.
Committed on 23/06/2024 at 09:02.
Pushed by igorkushnir into branch 'master'.
Remove useless [Indexed]QualifiedIdentifier conversions
DeclarationId::declaration[s]() construct a QualifiedIdentifier from an
IndexedQualifiedIdentifier and pass it to one of two functions. Each of
the two functions takes a `const IndexedQualifiedIdentifier& id`
parameter and assigns the `id` argument to a local variable before doing
anything else. Eliminate the redundant explicit conversion from
IndexedQualifiedIdentifier to QualifiedIdentifier and implicit
conversion back.
The only way this optimization can break something is if the local
variable `QualifiedIdentifier id` keeps the IndexedQualifiedIdentifier
valid somehow. But I do not think this is the case.
For some reason, KDevelop segfaulted during the implicit conversion back
from QualifiedIdentifier to IndexedQualifiedIdentifier in
DeclarationId::declaration() as described in Bug 482001. Hopefully this
optimization will eliminate the crash, or at least move elsewhere,
facilitate understanding and fixing it.
FIXED-IN: 5.15.240800
M +2 -2 kdevplatform/language/duchain/declarationid.cpp
https://invent.kde.org/kdevelop/kdevelop/-/commit/05878f92e82424df23a4e6e3c6a29883fbbedf4b
--
You are receiving this mail because:
You are watching all bug changes.
