https://bugs.kde.org/show_bug.cgi?id=482908

Fushan Wen <qydwhotm...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
                   |ma/plasma-workspace/-/commi |ma/plasma-workspace/-/commi
                   |t/9d92011d6022b57058ef8b02b |t/afa9e3406ba23a87cf4773f84
                   |5384f42e3e3f687             |f917d6466a33fa3

--- Comment #3 from Fushan Wen <qydwhotm...@gmail.com> ---
Git commit afa9e3406ba23a87cf4773f84f917d6466a33fa3 by Fushan Wen, on behalf of
Guilherme Silva.
Committed on 09/03/2024 at 06:03.
Pushed by fusionfuture into branch 'Plasma/6.0'.

libkmpris: prevent an empty icon from being used

The previous logic would only use the fallback icon
("emblem-music-symbolic"), if the client had the "DesktopEntry"
property[1] set.

But since clients are allowed to omit that property completely
(mpd-mpris[2] does that), m_iconName would stay an empty string, and
clients would be left icon-less.

This change ensures that m_iconName is never an empty string.

[1]
https://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html#Property:DesktopEntry
[2] https://github.com/natsukagami/mpd-mpris/


(cherry picked from commit 9d92011d6022b57058ef8b02b5384f42e3e3f687)

M  +3    -3    libkmpris/playercontainer.cpp
M  +1    -1    libkmpris/playercontainer.h

https://invent.kde.org/plasma/plasma-workspace/-/commit/afa9e3406ba23a87cf4773f84f917d6466a33fa3

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to