https://bugs.kde.org/show_bug.cgi?id=482908

Guilherme Silva <oguilhe...@protonmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/plasma-workspace/-/commi
                   |                            |t/9d92011d6022b57058ef8b02b
                   |                            |5384f42e3e3f687
         Resolution|---                         |FIXED

--- Comment #2 from Guilherme Silva <oguilhe...@protonmail.com> ---
Git commit 9d92011d6022b57058ef8b02b5384f42e3e3f687 by Guilherme Silva.
Committed on 09/03/2024 at 05:30.
Pushed by fusionfuture into branch 'master'.

libkmpris: prevent an empty icon from being used

The previous logic would only use the fallback icon
("emblem-music-symbolic"), if the client had the "DesktopEntry"
property[1] set.

But since clients are allowed to omit that property completely
(mpd-mpris[2] does that), m_iconName would stay an empty string, and
clients would be left icon-less.

This change ensures that m_iconName is never an empty string.

[1]
https://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html#Property:DesktopEntry
[2] https://github.com/natsukagami/mpd-mpris/

M  +3    -3    libkmpris/playercontainer.cpp
M  +1    -1    libkmpris/playercontainer.h

https://invent.kde.org/plasma/plasma-workspace/-/commit/9d92011d6022b57058ef8b02b5384f42e3e3f687

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to