https://bugs.kde.org/show_bug.cgi?id=476148
ratijas <m...@ratijas.tk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
|ma/discover/-/commit/576e46 |ma/discover/-/commit/da2342
|0ade383da789727066929d14baa |87041afdeaa68205a9783854722
|248aa02 |67705ec
--- Comment #6 from ratijas <m...@ratijas.tk> ---
Git commit da234287041afdeaa68205a978385472267705ec by ivan tkachenko.
Committed on 24/11/2023 at 18:25.
Pushed by ratijas into branch 'Plasma/5.27'.
Refactor roughCount into an atomic QGadget, fix usage of i18np
i18np's first argument should be a valid number. Meanwhile roughCount
was a string. Instead we should pass the original number as the
plural-deciding argument, while using the formatted string only for the
actual substitution.
It is only natural to factor out the counter into a gadget class of its
own, since all of its properties (and their semantics like the
`roughCount.length > 0` special case) change atomically and thus do not
require separate connections.
Also, let's store the Timer inline, instead of allocating dynamically.
(cherry picked from commit 576e460ade383da789727066929d14baa248aa02)
(and adapted to Qt 5)
M +1 -0 discover/DiscoverDeclarativePlugin.cpp
M +8 -9 discover/qml/ApplicationsListPage.qml
M +34 -13 libdiscover/resources/ResourcesProxyModel.cpp
M +29 -4 libdiscover/resources/ResourcesProxyModel.h
https://invent.kde.org/plasma/discover/-/commit/da234287041afdeaa68205a978385472267705ec
--
You are receiving this mail because:
You are watching all bug changes.
