https://bugs.kde.org/show_bug.cgi?id=476148
ratijas <m...@ratijas.tk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://invent.kde.org/plas
| |ma/discover/-/commit/576e46
| |0ade383da789727066929d14baa
| |248aa02
Status|ASSIGNED |RESOLVED
--- Comment #5 from ratijas <m...@ratijas.tk> ---
Git commit 576e460ade383da789727066929d14baa248aa02 by ivan tkachenko.
Committed on 24/11/2023 at 18:25.
Pushed by ratijas into branch 'master'.
Refactor roughCount into an atomic QGadget, fix usage of i18np
i18np's first argument should be a valid number. Meanwhile roughCount
was a string. Instead we should pass the original number as the
plural-deciding argument, while using the formatted string only for the
actual substitution.
It is only natural to factor out the counter into a gadget class of its
own, since all of its properties (and their semantics like the
`roughCount.length > 0` special case) change atomically and thus do not
require separate connections.
Also, let's store the Timer inline, instead of allocating dynamically.
M +1 -0 discover/DiscoverDeclarativePlugin.cpp
M +7 -8 discover/qml/ApplicationsListPage.qml
M +34 -13 libdiscover/resources/ResourcesProxyModel.cpp
M +27 -4 libdiscover/resources/ResourcesProxyModel.h
https://invent.kde.org/plasma/discover/-/commit/576e460ade383da789727066929d14baa248aa02
--
You are receiving this mail because:
You are watching all bug changes.
