https://bugs.kde.org/show_bug.cgi?id=436958

Wolfgang Bauer <wba...@tmo.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED
     Ever confirmed|0                           |1
                 CC|                            |wba...@tmo.at

--- Comment #19 from Wolfgang Bauer <wba...@tmo.at> ---
The fix broke kdiff3 in openSUSE, while 1.9.0 worked fine here.
The diff viewer is just black here now, and even clicking OK/Cancel in the
start dialog has no effect.

The kdiff3 package is built with NDEBUG defined, Qt is built in release mode.

Btw, I don't see how this can make sense:
#if defined(QT_NO_DEBUG)
#undef NDEBUG
#endif

Shouldn't it actually *define* NDEBUG if QT_NO_DEBUG is defined?
Otherwise NDEBUG will *enable* the assert, which seems to be counter-intuitive
IMHO. (NDEBUG is supposed to mean "no debug", isn't it?)

And I think the problem is exactly because assert() is also a no-op if NDEBUG
is defined. (i.e. the #undef apparently doesn't affect all necessary places, it
seems)

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to