https://bugs.kde.org/show_bug.cgi?id=414701
--- Comment #19 from Albert Astals Cid <aa...@kde.org> --- (In reply to Oliver Sander from comment #17) > I think I remember Kezi complaining about the ViewPort setting location > history events itself, too. Wouldn't it make more sense to make the code > that triggers the location change request explicitly that the old location > be recorded? Something like > > // an internal link has been clicked > recordLocation(here); > scrollTo(LinkDestination) He complained because he broke everything and it's easier to complain that the old code is wrong than to accept that your new code is not as good as you think it is. Let's be honest, the old code was perfectly working, going back and forth in history would animate the viewport (i still don't understand why we needed a new animation method while we had an existing one in place) and it did this animation without destroying history, so if the new code even with him introducing a new setViewportWithHistory method is not working, shows how bad the new code is. -- You are receiving this mail because: You are watching all bug changes.
