https://bugs.kde.org/show_bug.cgi?id=412561
Dmitry Kazakov <dimul...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/
|krita/commit/1fdbf7f5f57a73 |krita/commit/cd21bb33b70e0c
|61bb01d4ef42c83dd2c396cf4a |06426926c8c6c707cc540df464
--- Comment #18 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit cd21bb33b70e0c06426926c8c6c707cc540df464 by Dmitry Kazakov.
Committed on 11/11/2019 at 12:01.
Pushed by dkazakov into branch 'krita/4.2'.
Fix assert and a data-loss in Transform Tool
The patch rewrites the logic of transform stroke completion. Previously,
the decision whether to cancel transformation or to recover continued
state was done by the GUI thread. It cased troubles, because the user
could press esc/enter keys too quickly, even before the stroke was
actually initialized (and before sigTransactionGenerated() was received).
It caused confsion, resulting in the loss of the data of the continued
state.
Now GUI thread doesn't worry about the continued state. All the decisions
are done by the stroke itself, so no races should happen.
M +24 -20 plugins/tools/tool_transform2/kis_tool_transform.cc
M +2 -1 plugins/tools/tool_transform2/kis_tool_transform.h
M +53 -26
plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp
M +6 -2
plugins/tools/tool_transform2/strokes/transform_stroke_strategy.h
https://invent.kde.org/kde/krita/commit/cd21bb33b70e0c06426926c8c6c707cc540df464
--
You are receiving this mail because:
You are watching all bug changes.
