https://bugs.kde.org/show_bug.cgi?id=412561
Dmitry Kazakov <dimul...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://invent.kde.org/kde/
| |krita/commit/f336923b879653
| |edfbfc28fa29f839d456699e8c
Status|ASSIGNED |RESOLVED
--- Comment #16 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit f336923b879653edfbfc28fa29f839d456699e8c by Dmitry Kazakov.
Committed on 05/11/2019 at 18:41.
Pushed by dkazakov into branch 'master'.
Fix assert and a data-loss in Transform Tool
The patch rewrites the logic of transform stroke completion. Previously,
the decision whether to cancel transformation or to recover continued
state was done by the GUI thread. It cased troubles, because the user
could press esc/enter keys too quickly, even before the stroke was
actually initialized (and before sigTransactionGenerated() was received).
It caused confsion, resulting in the loss of the data of the continued
state.
Now GUI thread doesn't worry about the continued state. All the decisions
are done by the stroke itself, so no races should happen.
M +24 -20 plugins/tools/tool_transform2/kis_tool_transform.cc
M +2 -1 plugins/tools/tool_transform2/kis_tool_transform.h
M +53 -26
plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp
M +6 -2
plugins/tools/tool_transform2/strokes/transform_stroke_strategy.h
https://invent.kde.org/kde/krita/commit/f336923b879653edfbfc28fa29f839d456699e8c
--
You are receiving this mail because:
You are watching all bug changes.
