https://bugs.kde.org/show_bug.cgi?id=410355
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
Status|RESOLVED |REPORTED
Ever confirmed|1 |0
--- Comment #15 from Nate Graham <n...@kde.org> ---
(In reply to vialav from comment #14)
> I've just tested the patch and it has fixed my issue. Thank you for your
> coding.
Excellent! Of note, the bug can't be closed yet because the patch hasn't
actually gotten merged. Since you've tested it and verified that it works, it
would be very helpful if you could post a comment on
https://phabricator.kde.org/D22993 mentioning this (you can even formally
accept). That would help get it merged faster.
> I wondered where the stop-looking-for-nonexistent-file branch was planted as
> I could not find it on anongit.kde.org, and ended up downloading the raw
> diff from D22993.
Yep, that was the right way to do it (for now; once we move to GitLab there
will be branches you can download).
> Compiled with -Wsuggest-override there where some further overall
> suggestions, which are unrelated to this issue. Closing it as kindly fixed.
Please feel free to submit a patch that fixes those issues! See
https://community.kde.org/Infrastructure/Phabricator to learn how. You can just
paste a raw diff if you don't want to set up arcanist on your machine.
--
You are receiving this mail because:
You are watching all bug changes.
