https://bugs.kde.org/show_bug.cgi?id=397801

--- Comment #7 from trijez...@gmail.com ---
I have added the license field in the language tag in all three xml files.

https://github.com/trijezdci/M2-Syntax-Colour/commit/91dddc4e20d2b7de6fb9b416d0b9532b5beddc4c

I have also changed the mime type from x-modula-2 to x-modula2 as I think the
former is incorrect. On my system the registered mime type for Modula-2 is
x-modula2 and the Pygments plugin also has x-modula2. I have asked a friend to
check on his system and there, too, the mime type was x-modula2.

Looking at your list of xml files for syntax highlighting profiles, other than
Modula-2, there are eight other instances of languages with a hyphen in the
name:

ANS-Forth94 => ansforth94.xml : mimetype=""
B-Method => bmethod.xml : mimetype absent
Component-Pascal => component-pascal.xml : mimetype="text/x-component-pascal"
MS-DOS Batch => dosbat.xml : mimetype="application/x-dos"
G-Code => gcode.xml : mimetype="text/ngc"
Objective-C => objectivec.xml : mimetype="text/x-objc-src;text/x-c-hdr"
Objective-C++ => objectivecpp.xml : mimetype="text/x-objcpp-src;text/x-c-hdr"
POC-Ray => povray.xml : mimetype="text/x-povray-script;text/x-povray-include"

Of these, six have mimetypes, five of those drop the hypen in the mimetype,
only one preserves it. Component-Pascal appears to be the outlier.

I therefore suggest we drop the hyphen in the mimetype of Modula-2 as I have
(tentatively) done in the latest commit. If you see any issue with this, please
let me know and I will put the hyphen back in.

One could of course argue that if the hyphen is dropped in the mimetype, then
it should also be dropped in the filename to be consistent. The reason, I kept
the hyphen in the filename is because when I changed this, Kate did not
override the old incorrect Modula-2 xml entry with the replacement, but it
showed the old one in addition to the new ones in the language menu. So, I had
to keep the filename the same to override the old one.

Since there are already Kate installations our there which were shipped with
this file, I do not see how the old one could be overridden by the new one
without keeping the same filename.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to