https://bugs.kde.org/show_bug.cgi?id=392137

--- Comment #3 from Erik Quaeghebeur <k...@equaeghe.nospammail.net> ---
(In reply to Thomas Fischer from comment #2)
> I plan to make one more change before pushing it to the main repository:
> In IdSuggestionsEditWidget::IdSuggestionsEditWidgetPrivate::add(TokenType
> tokenType, bool atTop) you most likely copy'n'pasted from "case ttJournal",
> where len=1 is set. This means only the first letter of the journal or entry
> type is used, respectively. This may make sense for journals, where "JAAM"
> is a good abbreviation for a journal. For entry types which are without
> spaces, both "inbook" and "inproceedings" become just "i" and both "misc"
> and "mastersthesis" becomes "m". So, len should be -1. Do you agree?

I indeed ‘coded’ by copy-paste from the Journal Title ‘example’. However, I
intentionally kept "info.len = 1" because that is how I personally use it. I
don't mind inbook and inproceedings entries to both get an id with ‘i’ in the
same location. The ‘i’ of ‘in’ provides sufficient extra info. But I don't mind
at all if the default is changed to -1, as long as I can still manually set 1.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to