https://bugs.kde.org/show_bug.cgi?id=392137
Thomas Fischer <fisc...@unix-ag.uni-kl.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |ASSIGNED
--- Comment #2 from Thomas Fischer <fisc...@unix-ag.uni-kl.de> ---
I have committed your patch with only minimal changes. It is not yet in the
main repository, but you can inspect the commit here:
https://commits.kde.org/clones/kbibtex/thomasfischer/kbibtex/7bdc05e07ba3e92713ac57a0da54ea8c2a5bf4e1
I had your commit followed up by a change of myself to support
CamelCase-formatted entry types:
https://commits.kde.org/clones/kbibtex/thomasfischer/kbibtex/3511f0fb0576692596d874c0f58801d932ba19c4
I plan to make one more change before pushing it to the main repository:
In IdSuggestionsEditWidget::IdSuggestionsEditWidgetPrivate::add(TokenType
tokenType, bool atTop) you most likely copy'n'pasted from "case ttJournal",
where len=1 is set. This means only the first letter of the journal or entry
type is used, respectively. This may make sense for journals, where "JAAM" is a
good abbreviation for a journal. For entry types which are without spaces, both
"inbook" and "inproceedings" become just "i" and both "misc" and
"mastersthesis" becomes "m". So, len should be -1. Do you agree?
--
You are receiving this mail because:
You are watching all bug changes.
