https://bugs.kde.org/show_bug.cgi?id=356239
Dimitris Kardarakos <dimk...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |http://commits.kde.org/parl
| |ey/6efe4ae84f6c3fbeca8a7a4e
| |cf243669221dc5f1
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Dimitris Kardarakos <dimk...@gmail.com> ---
Git commit 6efe4ae84f6c3fbeca8a7a4ecf243669221dc5f1 by Dimitris Kardarakos.
Committed on 23/02/2016 at 14:08.
Pushed by dkardarakos into branch 'master'.
Fix Bug 356239 and facilitate proper grammar downloading
After porting to frameworks, only languages from the currently installed
language packages can be selected when creating a new collection.
Moreover, grammar fetching does not work in some cases even if the grammar file
exists in http://edu.kde.org/parley/locale/.
Instead of using QLocale().uiLanguages() in order to create the combobox of
to-be-selected languages, a key map has been created with
key = language-country, value = locale. Now, user is presented with a list of
Language (Country) entries. After selecting, the locale
(value of the key map) is set to the data part of the combobox. So, the looping
in uiLanguages() in DocumentProperties::acceptLanguageConfiguration
can be avoided. uiLanguages() returns an ordered list of locale names like
"en-Latn-US", "en-US", "en". E.g., in case of american english,
en-US is set. Trying to fetch the grammar from
http://edu.kde.org/parley/locale/, although en.kvtml exists, we cannot get the
grammar.
With this fix, locale info is stored as a string of the form "language_country"
(using QLocal name() function). When trying to fetch grammar,
only the first part (language) is used. Thus, de.kvtml, en.kvtml, es.kvtml,
fr.kvtml can now be properly downloaded.
REVIEW: 127063
M +1 -1 src/collection/collection.cpp
M +1 -1 src/parleydocument.cpp
M +31 -18 src/settings/documentproperties.cpp
M +6 -0 src/settings/documentproperties.h
M +3 -7 src/settings/languagepropertiespage.cpp
http://commits.kde.org/parley/6efe4ae84f6c3fbeca8a7a4ecf243669221dc5f1
--
You are receiving this mail because:
You are watching all bug changes.
