https://bugs.kde.org/show_bug.cgi?id=385097

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
      Latest Commit|https://commits.kde.org/pla |https://commits.kde.org/pla
                   |sma-workspace/bfe2539aa0553 |sma-workspace/54c13f4c8ae93
                   |6cf5e9c6b3327e5f1a6ebc91a73 |dd1b17f9d9a3a1a59e384d91ff4
         Resolution|---                         |FIXED

--- Comment #10 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 54c13f4c8ae93dd1b17f9d9a3a1a59e384d91ff4 by David Edmundson, on
behalf of Randy Kron.
Committed on 28/01/2018 at 21:18.
Pushed by davidedmundson into branch 'Plasma/5.12'.

Further improve quality of images in notifications

This revision further improves the quality of images in notifications
that was addressed in revision D9993. When I first looked into this, I
tried setting ScaleType on the PreviewJob but it had no effect. I found
that the preview images were being scaled to the small vertical size
that was requested, and this resulted in my first revision. I should
have tried setting ScaleType in addition.

Notification with unpatched libnotificationshelperplugin.so

{F5677396}

Notification with patch applied

{F5677397}

Test Plan:
Take screenshot with Spectacle with unpatched
libnotificationshelperplugin.so  installed and observe the blurry
preview image in the notification.

Install the patched libnotificationshelperplugin.so and restart
plasmashell.

Take another screenshot with Spectacle and observe the much improved
quality of the preview image in the notification.

Reviewers: #plasma_workspaces, #plasma, broulik, ngraham

Subscribers: #plasma, #plasma_workspaces, plasma-devel, broulik, ngraham

Tags: #plasma, #spectacle

Differential Revision: https://phabricator.kde.org/D10146

M  +1    -0    applets/notifications/plugin/thumbnailer.cpp

https://commits.kde.org/plasma-workspace/54c13f4c8ae93dd1b17f9d9a3a1a59e384d91ff4

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to