https://bugs.kde.org/show_bug.cgi?id=385097

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.12.0
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-workspace/bfe2539aa0553
                   |                            |6cf5e9c6b3327e5f1a6ebc91a73

--- Comment #5 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit bfe2539aa05536cf5e9c6b3327e5f1a6ebc91a73 by David Edmundson, on
behalf of Randy Kron.
Committed on 26/01/2018 at 16:54.
Pushed by davidedmundson into branch 'Plasma/5.12'.

Improve quality of images in notifications (Bug 385097)

Summary:
FIXED-IN: 5.12.0

This patch to plasma-workspace is to improve the quality of images in
notifications as reported in [[ https://bugs.kde.org/show_bug.cgi?id=385097 |
Bug 385097 ]].

It is still not perfect because KIO::PreviewJob is used to create the
thumbnail, and it only produces two sizes, 128px and 256px, so it is likely
that a small image will be scaled up, blurring it somewhat.

I took two screenshots of the same Dolphin window. Here is the before, without
the patch:
{F5665511}

And the after, with the patch:
{F5665513}

Better, but still not perfect.

Test Plan: Take screenshots with Spectacle with and without the patched
libnotificationshelperplugin library and observe the image quality in the
notification. plasmashell must be restarted when the library file is changed
for it to take effect.

Reviewers: #plasma_workspaces, #plasma, broulik

Reviewed By: #plasma_workspaces, #plasma, broulik

Subscribers: broulik, ngraham, plasma-devel, #plasma_workspaces, #plasma

Tags: #spectacle, #plasma

Differential Revision: https://phabricator.kde.org/D9993

M  +2    -1    applets/notifications/plugin/thumbnailer.cpp

https://commits.kde.org/plasma-workspace/bfe2539aa05536cf5e9c6b3327e5f1a6ebc91a73

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to