https://bugs.kde.org/show_bug.cgi?id=381105

--- Comment #40 from Kai Uwe Broulik <k...@privat.broulik.de> ---
Git commit 8f435a2dbde4c8f69800ed27878d89be0dfc8356 by Kai Uwe Broulik.
Committed on 15/08/2017 at 09:49.
Pushed by broulik into branch 'Plasma/5.10'.

[Notifications] Clean up States

While I'm usually a huge fan of States, this is done only half-way with States
in the compact
representation (NotificationIcon) overwriting the plasmoid's state in addition
to there being
a binding on it in main.qml.

It also used a "default" state (note: the default state in QML is empty string)
in addition to
assigning default values on items themselves anyway.

This seems to shift evaluation of bindings into an order where we first stop
the BusyIndicator
and then become passive, moving the the systray popup, working around the Qt
crash we're seeing.

It's a nice clean up in any case imho.

Differential Revision: https://phabricator.kde.org/D7319

M  +12   -36   applets/notifications/package/contents/ui/NotificationIcon.qml
M  +1    -7    applets/notifications/package/contents/ui/main.qml

https://commits.kde.org/plasma-workspace/8f435a2dbde4c8f69800ed27878d89be0dfc8356

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to