https://bugs.kde.org/show_bug.cgi?id=509590

--- Comment #4 from Mark Wielaard <[email protected]> ---
(In reply to mcermak from comment #3)
> Created attachment 185023 [details]
> proposed patch
> 
> One more update re $(nproc) auxprogs/Makefile.am.

I think the patch is OK. But I don't understand this change.

-        ${MAKE} -j $(nproc) -C testcases/kernel/syscalls)
+        ${MAKE} clean && \
+        ${MAKE} -j $(shell nproc) -C testcases/kernel/syscalls)

Why and what does it do?

I understand the clean part, that is to make sure the next make invocation
really builds the syscalls tests.

But why and what does the $(shell ...) part do?

And do really need/want that here?
I understand the -j $(nproc) part was there before.
But now that we are changing it should it really be there?
I though that a sub-make always communicated through the jobserver started by
the parent make to control parallelism.
So can we just remove the whole -j ... part?

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to