https://bugs.kde.org/show_bug.cgi?id=509590
Mark Wielaard <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REPORTED |CONFIRMED CC| |[email protected] Ever confirmed|0 |1 --- Comment #1 from Mark Wielaard <[email protected]> --- I like it. Just some nitpicks. - Please also add it to NEWS. - The ltp-patches/0002-Introduce-LTP_QUIET-env-var.patch should be added to auxprogs/Makefile.am (LTP_PATCHES) otherwise it won't be added to the dist on release. - I had some trouble getting it applied because I already had build auxprogs/auxchecks/ltp-full-20250530 Lets add the patches and the patch script as dependencies. And be more aggressive rebuilding. e.g diff --git a/auxprogs/Makefile.am b/auxprogs/Makefile.am index 4f9f100c0389..1e09d16c5ec3 100644 --- a/auxprogs/Makefile.am +++ b/auxprogs/Makefile.am @@ -21,7 +21,8 @@ LTP_FILTERS = \ filters/select03 LTP_PATCHES = \ - ltp-patches/0001-Make-sure-32-bit-powerpc-syscall-defs-don-t-leak-to-.patch + ltp-patches/0001-Make-sure-32-bit-powerpc-syscall-defs-don-t-leak-to-.patch \ + ltp-patches/0002-Introduce-LTP_QUIET-env-var.patch EXTRA_DIST = \ docs/valgrind-listener-manpage.xml \ @@ -211,14 +212,14 @@ $(GSL_SRC_DIR)/gsl-patched: $(GSL_TAR) autoreconf -f -i -Wnone) touch $@ -$(LTP_SRC_DIR): $(LTP_TAR) +$(LTP_SRC_DIR): $(LTP_TAR) ltp-apply-patches.sh $(LTP_PATCHES) echo "$(LTP_SHA256_SUM) $(LTP_TAR)" | @SHA256SUM@ --check - (cd $(AUX_CHECK_DIR) && \ tar Jxf $(LTP_TAR_NAME) && \ $(abs_top_srcdir)/auxprogs/ltp-apply-patches.sh $(LTP_SRC_DIR) && \ cd $(LTP_SRC_DIR) && \ ./configure CC="${CC}" CXX="${CXX}" CFLAGS="$(LTP_CFLAGS)" && \ - ${MAKE} -j $(nproc) -C testcases/kernel/syscalls) + ${MAKE} -B -j $(nproc) -C testcases/kernel/syscalls) touch $@ -- You are receiving this mail because: You are watching all bug changes.
