chia7712 commented on code in PR #20724:
URL: https://github.com/apache/kafka/pull/20724#discussion_r2475126513
##########
server-common/src/test/java/org/apache/kafka/queue/KafkaEventQueueTest.java:
##########
@@ -435,7 +435,7 @@ public void testIdleTimeCallback() throws Exception {
logContext,
"testIdleTimeCallback",
EventQueue.VoidEvent.INSTANCE,
- lastIdleTimeMs::set)) {
+ (idleDuration, currentTime) ->
lastIdleTimeMs.set(idleDuration))) {
Review Comment:
Should we add a unit test for this new value `currentTime`?
##########
metadata/src/main/java/org/apache/kafka/image/loader/MetadataLoader.java:
##########
@@ -217,10 +218,11 @@ private MetadataLoader(
faultHandler,
this::maybePublishMetadata);
this.eventQueue = new KafkaEventQueue(
- Time.SYSTEM,
+ time,
Review Comment:
Nice job!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
