jsancio commented on code in PR #20724:
URL: https://github.com/apache/kafka/pull/20724#discussion_r2469552485
##########
metadata/src/main/java/org/apache/kafka/image/loader/metrics/MetadataLoaderMetrics.java:
##########
@@ -47,10 +49,13 @@ public final class MetadataLoaderMetrics implements
AutoCloseable {
"MetadataLoader", "HandleLoadSnapshotCount");
private static final MetricName CURRENT_CONTROLLER_ID = getMetricName(
"MetadataLoader", "CurrentControllerId");
+ private static final MetricName AVERAGE_IDLE_RATIO = getMetricName(
+ "MetadataLoader", "AvgIdleRatio");
private static final String FINALIZED_LEVEL_METRIC_NAME = "FinalizedLevel";
private static final String FEATURE_NAME_TAG = "featureName";
private final Optional<MetricsRegistry> registry;
+ private final Time time;
Review Comment:
You can remove this requirement now. This component is not used anymore.
##########
server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java:
##########
@@ -444,15 +445,15 @@ int size() {
/**
* Optional callback for queue idle time tracking.
*/
Review Comment:
I recommend documenting the two parameter. E.g. what is the first Long vs
the second Long to the BiConsumer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
