joshua2519 commented on code in PR #20293:
URL: https://github.com/apache/kafka/pull/20293#discussion_r2393395848
##########
tools/src/test/java/org/apache/kafka/tools/streams/DeleteStreamsGroupOffsetTest.java:
##########
@@ -132,6 +132,7 @@ public void testDeleteOffsetsNonExistingGroup() {
Map.Entry<Errors, Map<TopicPartition, Throwable>> res =
service.deleteOffsets();
assertEquals(Errors.GROUP_ID_NOT_FOUND, res.getKey());
}
+ assertEquals(0, StreamsGroupCommand.execute(args));
Review Comment:
I agree with your idea. I removed the unnecessary tests and add tests to
execute() to verify the return code for different errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
