mjsax commented on code in PR #20293:
URL: https://github.com/apache/kafka/pull/20293#discussion_r2377363240
##########
tools/src/test/java/org/apache/kafka/tools/streams/DeleteStreamsGroupOffsetTest.java:
##########
@@ -132,6 +132,7 @@ public void testDeleteOffsetsNonExistingGroup() {
Map.Entry<Errors, Map<TopicPartition, Throwable>> res =
service.deleteOffsets();
assertEquals(Errors.GROUP_ID_NOT_FOUND, res.getKey());
}
+ assertEquals(0, StreamsGroupCommand.execute(args));
Review Comment:
Given that this PR only modifies StreamsGroupCommand methods like
`main()/execute()` and `run()` but not the "sub methods, it seem unnecesary.
It could make sense to have a single test in `StreamsGroupCommandTest` to
verify that any error from a sub-method is translated into `1` return code, and
no error returns `0`. But it seems redundant to re-test this for each of the
sub-commands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
